Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Fieldset layout broken if span.label is used instead of label #51

Open
oleonard opened this issue Sep 27, 2022 · 2 comments
Open

Fieldset layout broken if span.label is used instead of label #51

oleonard opened this issue Sep 27, 2022 · 2 comments
Assignees
@jajm
Labels
status: needs testing A patch is available and needs to be tested type: bug Something isn't working

Comments

@oleonard
Copy link
Contributor

If you're using <fieldset class="rows"> to trigger a form layout inside an <ol>, you're supposed to be able to use both (for a form control) or <span class="label"> for an element which looks like a label but isn't associated with an input field.

In our production system:
Screenshot 2022-09-27 at 11-10-50 Batch 23989 › Manage staged MARC records › Tools › Koha

In the redesign:
Screenshot 2022-09-27 at 11-10-37 Batch 39 › Manage staged MARC records › Tools › Koha
@jajm jajm added the type: bug Something isn't working label Sep 28, 2022
jajm added a commit that referenced this issue Sep 28, 2022
@jajm
Bug 30952: Add label style to label class inside fieldset.rows
81ef68c 
Issue #51
@jajm
Copy link
Owner

jajm commented Sep 28, 2022

Fixed

image

@jajm jajm self-assigned this Sep 28, 2022
@jajm jajm added the status: needs testing A patch is available and needs to be tested label Sep 28, 2022
jajm added a commit that referenced this issue Oct 12, 2022
@jajm
Bug 30952: Add label style to label class inside fieldset.rows
fe2f907 
Issue #51
@mrenvoize
Copy link
Contributor

Great, another one that can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jajm jajm

Labels
status: needs testing A patch is available and needs to be tested type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jajm @mrenvoize @oleonard