Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

System preference <td> on preferences.tt are the same color background as the <body> background #55

Closed
ricofreak opened this issue Sep 28, 2022 · 7 comments

Comments

@ricofreak
Copy link
Contributor

ricofreak commented Sep 28, 2022

If you search for system preferences the <td>'s have a background color (#f3f4f4) which is exactly the same as the <body> background. I end up losing my place as I cannot see where the <td> ends.

@ricofreak
Copy link
Contributor Author

This actually effects most tables. It makes the table blend with the body background color. Do we need to add some kind of table border?

@mrenvoize
Copy link
Contributor

Aha, I resolved this elsewhere by ensuring 'content' was inside a 'page-section'.. i.e. it had a white background... this is one I think we should all help with as follow-ups after push.. spread the load.

@mrenvoize
Copy link
Contributor

See issue #45 and issue #22 for some further details around this @ricofreak

@mrenvoize
Copy link
Contributor

Adding the 'page-section' class to the divs with 'prefs-tab' class yields this @ricofreak, does that work for you?

screenshot-pro-mt38042-koha demo biblibre eu-2022 10 03-13_33_20

@ricofreak
Copy link
Contributor Author

Yes, that looks much better to me! Thanks!

@mrenvoize
Copy link
Contributor

OK.. I'll add that as a bug on bugzilla now.. the screenshot was just a test I did locally.. I'll go ahead and work through the codebase adding page-section divs.

@mrenvoize
Copy link
Contributor

See bug 31758

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants