Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing cobra library dependency #2012

Open
gkerdal opened this issue Mar 19, 2017 · 8 comments
Open

Removing cobra library dependency #2012

gkerdal opened this issue Mar 19, 2017 · 8 comments

Comments

@gkerdal
Copy link
Contributor

gkerdal commented Mar 19, 2017

Here is a new topic for discussing how to remove cobra library dependency.

Context : cobra is a graphical library used in jajuk to show wikipedia web content.
The library doesn't seem to be maintained, it has been fixed by jajuk team for the 1.10 Jajuk version to fix a bug.

Bertrand suggested me the link [1] below to replace the Wikipedia view.

I managed to make it work on a prototype version of Jajuk with Oracle JDK 8 installed (Ubuntu).
The content of wikipedia is correctly displayed, even images, it may require a bit more ressources than cobra library but it's just my opinion.

Before going further testing, let's discuss this JavaFx solution.

JavaFx seems only integrated in Oracle JVM since Java 7 (u 6). On previous version it is a separate component, but that's not a big drawback since Jajuk now requires Java 7.

I found on the [2] link that JavaFX si not yet integrated in Open jdk 1.8. So using JavaFX may force Jajuk users to install proprietary Oracle Jvm, not sure it's compatible with jajuk's principles.
What do you think ?

[1] https://docs.oracle.com/javase/8/javafx/interoperability-tutorial/swing-fx-interoperability.htm
[2] http://stackoverflow.com/questions/28142746/is-javafx-supported-in-openjdk

@bflorat
Copy link
Contributor

bflorat commented Mar 20, 2017

Thanks Gwen for your searches. IMO, it's a NO-GO if we need an Oracle JDK (and anyway, I suppose I wouldn't work on OSX).
So you found a new java lib ;-) ?

@gkerdal
Copy link
Contributor Author

gkerdal commented Apr 2, 2017

Hi Bertrand,
I agree too, that's too restrictive. I'll have a look at CSSBox library. If you ever heard about anything else, let me know, I can have a look.

@bflorat
Copy link
Contributor

bflorat commented Apr 3, 2017

Hi Gwen, no, I'm not aware of any other solution.
Just make sure that any new lib is well supported, is cross-platform (linux/windows/OSX) : 100% pure java like cobra if possible.

Being already packaged into Debian would be a big plus.
Cheers,
Bertrand

@bflorat
Copy link
Contributor

bflorat commented Nov 19, 2017

I may have a solution : from jre 8, the Swing JTextPane seems to be enough for our needs. I tested it and it looks acceptable to me (and the user can click on the rocket to open the wikipedia page in a regular browser) :

image

What do you think ? want me to push my changes so you can have a look ?

@gkerdal
Copy link
Contributor Author

gkerdal commented Nov 19, 2017 via email

@bflorat
Copy link
Contributor

bflorat commented Nov 20, 2017

Please check out the feature/html branch. It contains a very naive POC of the solution.

@gkerdal
Copy link
Contributor Author

gkerdal commented Nov 26, 2017 via email

@bflorat
Copy link
Contributor

bflorat commented Nov 27, 2017

All right, I'll have a look at it. My current implementation is very basic.

Thanks, Bertrand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants