Add support for running TCK using Java 21 #72
Conversation
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
|
@scottkurz Looks great! I'll verify this and let you know the running result :D |
|
I have verified this locally and it passed the sigtests: 
I'll update this PR to verify the test results on Github CI: @scottkurz Thanks for working on this! btw, could you please teach me how you generate the |
|
|
||
|
|
||
|
|
||
| 4. **Signature Test Tool** - No action is needed here, but we note that the Java 11 and 17 signature files were built with the Maven plugin with group:artifact:version coordinates: **org.netbeans.tools:sigtest-maven-plugin:1.6**. The Java 21 signature file was built with the newer plugin maintained by the EE4J organization, with coordinates: **jakarta.tck:sigtest-maven-plugin:2.2**. The sample sigtest runner included in the TCK zip also uses the EE4J plugin, and it acan be used to validate an implementation using one of the Java 11 or 17 signature files (built by the other plugin) as well as the newest Java 21 signature file. Though there are other signature test tools available, one of these two tools should be used when executing this TCK. |
There was a problem hiding this comment.
*jakarta.tck:sigtest-maven-plugin:2.2* should be good to use but we can always upgrade to newer versions if needed.
I think that *jakarta.tck:sigtest-maven-plugin:2.3* will likely include the eclipse-ee4j/jakartaee-tck-tools#30 change which changes the -IgnoreJDKClass option to no longer take the list of JDK classes to be specified, instead we will ignore the java.* + javax.transaction.xa which is more future proof (as long as the *jakarta.tck:sigtest-maven-plugin:2.3* code works on whichever future Java SE version).
*jakarta.tck:sigtest-maven-plugin:2.3* will also include eclipse-ee4j/jakartaee-tck-tools#31 which addresses a java.util.ConcurrentModificationException failure in the PackageGroup.checkName() method (I have seen this failure intermittently with Platform TCK testing).
There was a problem hiding this comment.
With the -IgnoreJDKClass option specified, we could then just use the sigtest-1.6-batch.standalone.tck.sig-2.1-se11-OpenJDK-J9 file on Java 11/17/21
There was a problem hiding this comment.
That sounds useful... and appreciate the info. It sounds like we can queue this up for a future enhancement, so I opened #73 and referenced this comment.
Since I have a typo in there anyway... acan ...let me come back and soften the language a bit.
You could run something like: |
Thanks for teaching! |
Signed-off-by: Scott Kurz <skurz@us.ibm.com>
|
@scottkurz Do you have a plan to do a release to include this change? If there is a new release I'll update the JBeret TCK testing project accordingly: |
@liweinan I'm working on the plan. I'd like to do one Service Release which provides the Java 21 support and also addresses TCK challenge: #71 Since that fix I'd thought should include a spec doc update I'm just educating myself on how to this in the Jakarta process. Will send an update to the Jakarta Batch mailing list too when I can confirm the process steps. |
|
@scottkurz Thanks for working on this! |
Fixes #66. See checklist for some details.
Will worry about the release details somewhere else..this is just providing the content.
@liweinan does this look good to you?