Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TCK coverage for BeanManager.getContexts() #396

Closed
manovotn opened this issue Jul 18, 2022 · 2 comments · Fixed by #483
Closed

Create TCK coverage for BeanManager.getContexts() #396

manovotn opened this issue Jul 18, 2022 · 2 comments · Fixed by #483
Milestone

Comments

@manovotn
Copy link
Contributor

Related specification issue - jakartaee/cdi#628

Tracking issue for TCK tests for this feature. Note that the feature is scheduled for next CDI version (beyond 4.0).
The test should probably use a custom scope with custom context as all impls can (in theory) have multiple contexts per given built-in scope making assertions on that unreliable.

@Ladicek
Copy link
Contributor

Ladicek commented Jul 18, 2022

Also we probably should have 2 variants of the same test -- one for context registered through BCExtension, and another one for context registered through PExtension.

@manovotn
Copy link
Contributor Author

I think the BCE variant would be enough.

With PE, you don't even need the method to begin with. Plus BM needs to have references to all instances of contexts anyway since you can already browse them when active. Therefore, so long as registration works (for which there should be different test already), you will see it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants