Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.jboss.cdi.tck.tests.context.DestroyForSameCreationalContext2Test isn't marked as "full" and uses session context and custom Contextual #457

Closed
Ladicek opened this issue May 1, 2023 · 1 comment · Fixed by #458
Labels
accepted Issue/challenge is accepted challenge TCK test challenge

Comments

@Ladicek
Copy link
Contributor

Ladicek commented May 1, 2023

The test DestroyForSameCreationalContext2Test repeats the exact same 2 assertions against a session context and a request context. To do that, it also uses a custom implementation of the Contextual interface. This test isn't marked as "full", and isn't a full package, because it makes sense for CDI Lite as well -- except CDI Lite implementations are not required to provide the session context and don't necessarily have to support custom implementations of Contextual.

I believe we should move the test to the full package.

@Ladicek Ladicek added the challenge TCK test challenge label May 1, 2023
@Ladicek Ladicek changed the title org.jboss.cdi.tck.tests.context.DestroyForSameCreationalContext2Test isn't marked as "full" and uses session context org.jboss.cdi.tck.tests.context.DestroyForSameCreationalContext2Test isn't marked as "full" and uses session context and custom Contextual May 1, 2023
@manovotn
Copy link
Contributor

manovotn commented May 2, 2023

I agree, we likely missed this test initially. All tests using session context should have been either rewritten or moved to full.

@manovotn manovotn added the accepted Issue/challenge is accepted label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issue/challenge is accepted challenge TCK test challenge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants