BeanContainer#getInjectableReference should probably be on BeanManager instead #568
Assignees
Labels
Lite
Related to CDI Lite
Comments
|
Technically, we don't "allow Lite implementations to support |
True, I was to lazy to search for exact wording in the spec :) |
This was referenced Dec 7, 2021
Ladicek
added a commit
to Ladicek/cdi-spec
that referenced
this issue
May 31, 2023
… Full We previously [1] moved the `getInjectableReference()` from the `BeanContainer` interface to the `BeanManager` [2], but did not update the specification text accordingly. Thus, the method is specified in the CDI Lite part of the spec, but it in fact belongs to CDI Full. This commit moves the spec text around to fix that. Additionally, this commit removes the declaration of `resolveObserverMethods()` from `BeanManager`, because that just overrides the same declaration that is present on `BeanContainer`. Finally, this commit moves the declaration of `getInjectableReference()` from the end of the `BeanManager` source code to the beginning, for symmetry with the `BeanContainer` declaration and to restore the previous layout. [1] jakartaee@520bad1 [2] jakartaee#568
Ladicek
added a commit
that referenced
this issue
May 31, 2023
… Full We previously [1] moved the `getInjectableReference()` from the `BeanContainer` interface to the `BeanManager` [2], but did not update the specification text accordingly. Thus, the method is specified in the CDI Lite part of the spec, but it in fact belongs to CDI Full. This commit moves the spec text around to fix that. Additionally, this commit removes the declaration of `resolveObserverMethods()` from `BeanManager`, because that just overrides the same declaration that is present on `BeanContainer`. Finally, this commit moves the declaration of `getInjectableReference()` from the end of the `BeanManager` source code to the beginning, for symmetry with the `BeanContainer` declaration and to restore the previous layout. [1] 520bad1 [2] #568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
BeanContainerAPI currently housesgetInjectableReference(InjectionPoint ij, CreationalContext<?> ctx)which was originally onBeanManager.After some discussion with @Ladicek we arrived at the conclusion that this doesn't make much sense.
In Lite, you don't have access (via
BeanContainer) to programmatic creation ofInjectionPointbecause that's based off the former metadata model (AnnotatedTypeand friend). You cannot store them from extensions either so your means of getting hold of them are very limited. Possibly only to creating a class directly implementing an IP which, again, requires usage of theAnnotated*metamodel.Therefore, we should move this method back to
BeanManager.Note that recently we changed the wording so that implementations in Lite are allowed to support
BeanManagerin some limited form as well meaning that if this functionality turns out to be needed, it can still be implemented without breaking spec compatibility.The text was updated successfully, but these errors were encountered: