create resource definition annotations for Concurrency #141
Conversation
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11
force-pushed
the
38-resource-definition-annotations
branch
from
20988c2
to
cb5a598
Compare
| * <p>The amount of time in milliseconds that a task or action | ||
| * can execute before it is considered hung.</p> | ||
| * | ||
| * <p>The default value of <code>-1</code> indicates unknown.</p> |
There was a problem hiding this comment.
What does unknown mean here? Is this meant to be unlimited?
There was a problem hiding this comment.
Yes, it was intended to say unlimited. This, and the other occurrence are corrected under 6b80fec
| public @interface ManagedExecutorDefinition { | ||
| /** | ||
| * JNDI name of the {@link ManagedExecutorService} instance. | ||
| * The JNDI name must must be in a valid Jakarta EE namespace, |
There was a problem hiding this comment.
Thanks for spotting that. This, and the other occurrences of it, are fixed under 6b80fec
| * <p>The amount of time in milliseconds that a task or action | ||
| * can execute before it is considered hung.</p> | ||
| * | ||
| * <p>The default value of <code>-1</code> indicates unknown.</p> |
There was a problem hiding this comment.
What does unknown mean here? Is this meant to be unlimited?
| public @interface ManagedThreadFactoryDefinition { | ||
| /** | ||
| * JNDI name of the {@link ManagedThreadFactory} instance. | ||
| * The JNDI name must must be in a valid Jakarta EE namespace, |
| * <pre> | ||
| * <resource-env-ref> | ||
| * <resource-env-ref-name>java:module/env/concurrent/MyExecutorRef</resource-env-ref-name> | ||
| * <resource-env-ref-type>javax.enterprise.concurrent.ManagedExecutorService</resource-env-ref-type> |
There was a problem hiding this comment.
Please update javax to jakarta
There was a problem hiding this comment.
This and the other occurrences of it are also corrected under 6b80fec
| * <pre> | ||
| * <resource-env-ref> | ||
| * <resource-env-ref-name>java:comp/env/concurrent/MyScheduledExecutorRef</resource-env-ref-name> | ||
| * <resource-env-ref-type>javax.enterprise.concurrent.ManagedScheduledExecutorService</resource-env-ref-type> |
There was a problem hiding this comment.
Please update javax to jakarta
| * <pre> | ||
| * <resource-env-ref> | ||
| * <resource-env-ref-name>java:module/env/concurrent/MyThreadFactoryRef</resource-env-ref-name> | ||
| * <resource-env-ref-type>javax.enterprise.concurrent.ManagedThreadFactory</resource-env-ref-type> |
There was a problem hiding this comment.
Please update javax to jakarta
| * <pre> | ||
| * <resource-env-ref> | ||
| * <resource-env-ref-name>java:app/env/concurrent/MyContextRef</resource-env-ref-name> | ||
| * <resource-env-ref-type>javax.enterprise.concurrent.ContextService</resource-env-ref-type> |
There was a problem hiding this comment.
Please update javax to jakarta
This pull is the first step toward #38
It creates resource definition annotations:
@ContextServiceDefinition@ManagedExecutorDefinition@ManagedScheduledExecutorDefinition@ManagedThreadFactoryalong with a handful of attributes for each - hopefully the most basic ones that will be common across implementations and therefore non-controversial. More can certainly be added in follow-on pulls. I have not marked this pull to close out the issue, so that separate pulls will still be able to further build on top of this, adding in whatever other config is agreed upon.
Actions to accomplish after this pull goes in:
<context-service>,<managed-executor>,<managed-scheduled-executor>,<managed-thread-factory>definitions in deployment descriptor schemaSigned-off-by: Nathan Rauh nathan.rauh@us.ibm.com