Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContextService update #159

Merged
merged 2 commits into from Dec 6, 2021
Merged

ContextService update #159

merged 2 commits into from Dec 6, 2021

Conversation

mswatosh
Copy link
Member

@mswatosh mswatosh commented Dec 2, 2021

Clarification on when context is captured for the ContextService methods.

@mswatosh mswatosh self-assigned this Dec 2, 2021
@mswatosh mswatosh requested review from njr-11 and removed request for njr-11 December 2, 2021 22:16
@mswatosh mswatosh requested a review from njr-11 December 2, 2021 22:20
njr-11
njr-11 approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the extra clarification to the JavaDoc. The changes look great. You might need to clean up some trailing whitespace to get checkstyle to pass.

@mswatosh mswatosh requested a review from njr-11 December 2, 2021 22:42
@njr-11 njr-11 added this to the 3.0 milestone Dec 3, 2021
@mswatosh mswatosh merged commit 211abda into jakartaee:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smillidge smillidge smillidge approved these changes

@njr-11 njr-11 njr-11 approved these changes

Assignees

@mswatosh mswatosh

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mswatosh @smillidge @njr-11