Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forgotten counter reset before tests #222

Merged

Conversation

aubi
Copy link
Contributor

@aubi aubi commented May 13, 2022

The counter wasn't reset before tests, running other tests influence this one.

I will follow the challenge process.

@aubi aubi force-pushed the add-forgotten-counter-reset-before-tests branch from 0600967 to f4839ef Compare May 13, 2022 14:16
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a new test, but the proposed change looks valid to me given that the same counter is used by other tests.

@smillidge smillidge added the TCK label May 19, 2022
@smillidge smillidge merged commit 6b6a539 into jakartaee:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants