Remove unused parameter #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjantijms
approved these changes
Jun 19, 2022
njr-11
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Looks good to me.
I recommend waiting to merge this until after the 3.0.1 maintenance release so that the maintenance release only includes TCK fixes for the challenged tests, and not any changes to the API jar (although I realize this change has no impact at all on the API or behavior and is only code cleanup).
We already have a 3.0.1 release for the API pom in our planning, don't we? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.