@ConfigMapping specification #232
Conversation
radcortez
force-pushed
the
mappings
branch
3 times, most recently
from
2453402
to
21320e6
Compare
| @Documented | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target({ ElementType.METHOD }) | ||
| public @interface ConfigDefault { |
There was a problem hiding this comment.
What about ConfigValue or ConfigDefaultValue?
There was a problem hiding this comment.
If it is only available in a @ConfigMapping class/interface, I would like move these annotations(ConfigName, ConfigDefault) into ConfigMapping and remove the Config prefix, eg. @Key, @DefaultValue.
@interface ConfigMapping{
@interface Key{}
@interface DefaultValue{}
}There was a problem hiding this comment.
Use a Config prefix everywhere make the codes looks tedious.
There was a problem hiding this comment.
Sounds reasonable. I'll have a look.
|
@radcortez Why was this merged? Did someone approve it? |
We discussed the PR during two meetings, and I thought there were no objections to what was being proposed. Sorry for moving ahead; I wanted to have the code merged so I could keep moving forward with some consistency work and other proposals that impact the general codebase. Feel free to point out any issues and I'm happy to fix them in another PR. |
No description provided.