Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small typo: dara -> data #197

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

geertschuring
Copy link
Contributor

I noticed the smallest possible typo while reading the readme of the repo. Here's my contribution to the world of data access :)

@otaviojava
Copy link
Contributor

@geertschuring could you check the ECA.

@geertschuring
Copy link
Contributor Author

@geertschuring could you check the ECA.

I've signed the ECA successfully, but the "revalidate" button on the GIT ECA Validation Status page [1] doesn't work.
Not sure how to fix this.

[1] https://api-staging.eclipse.org/git/eca/status/gh/jakartaee/data/197

@geertschuring
Copy link
Contributor Author

There's something strange going on here... first it says my ECA is valid, en then it says its not.

image

Does anyone know who to contact about this?

@otaviojava
Copy link
Contributor

@geertschuring
Copy link
Contributor Author

geertschuring commented Jul 26, 2023

Did you do the DCO? https://github.com/eclipse/jnosql/blob/main/CONTRIBUTING.adoc#developer-certificate-of-origin---dco

I just used the github feature to fork, change, and create PR. That should really just work. I've been contributing to OS projects for a long time and never run into this kind of problems. I've mailed the apache webmaster to ask for help.
Feel free to use this PR for inspiration, apply the fix yourself and delete this PR if you like.

@otaviojava otaviojava merged commit e6f8cf3 into jakartaee:main Jul 26, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants