Replacing assertion libraries: Hamcrest by AssertJ #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replace all the assertions from Hamcrest by AssertJ, adding more fluent assertions through soft assertions.
This change replace all the assertions from Hamcrest by AssertJ, adding more fluent assertions through soft assertions. Three tests was also removed as they are now redundant: shouldCreateOrder(), shouldAscending() and shouldDescending()
Replace of Hamcrest by AssertJ to add more fluent assertions. Additionally, added a property to easily update the assertj-core version
JUnit and Mockito are now using the latest versions. Fix typo in the mockito version property
otaviojava
reviewed
Oct 3, 2022
Co-authored-by: Otávio Santana <otaviopolianasantana@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR replaces Hamcrest with AssertJ in order to add more fluent and understandable assertions.
Changed
jakarta-data-apihamcrest-allin favour ofassertj-corePageableTestandSortTestSortTestjakarta-data-parentmockito.versionto4.8.0`junitto5.9.0mockito.version