Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lots of improvements to the Javadoc #531

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Conversation

gavinking
Copy link
Contributor

including some fixes to out of date info in module-info.java

see #519

including some fixes to out of date info in module-info.java

see jakartaee#519
@gavinking gavinking marked this pull request as ready for review March 8, 2024 12:45
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some minor comments

api/src/main/java/module-info.java Outdated Show resolved Hide resolved
api/src/main/java/module-info.java Outdated Show resolved Hide resolved
api/src/main/java/module-info.java Outdated Show resolved Hide resolved
api/src/main/java/module-info.java Outdated Show resolved Hide resolved
api/src/main/java/module-info.java Outdated Show resolved Hide resolved
api/src/main/java/module-info.java Outdated Show resolved Hide resolved
gavinking and others added 2 commits March 8, 2024 18:17
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
@gavinking
Copy link
Contributor Author

Add some minor comments

I accepted some of them, and pushed a commit with an alternative solution to two of them.

Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good now.

@njr-11 njr-11 merged commit 7a6a525 into jakartaee:main Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants