-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split repository.asciidoc into multiple files #585
Conversation
and split chapter 3 into sections, instead of hanging everything off section 3.1
|
||
=== Entity Names and Persistent Field Names | ||
|
||
Entities and their persistent fields may be referenced by name in the query language defined in <<Jakarta Data Query Language>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this one-sentence preamble to section 3.2 is the only change to the actual words.
@njr-11 do you have any objection to making this change, before it starts running into conflicts? |
I forgot about this one. I remember seeing it and not wanting to spend time comparing the files to ensure nothing was left out, so I set it aside for later. If you or another reviewer has already verified that, I'm fine with it. |
Well, the difference in linecount should be 13+2+2-1 = 16 lines (a copyright header, two includes, the one added line of text, minus a heading. And 669-653 = 16, so that checks out. |
I double checked in a diff tool and confirmed nothing is left out. Just the change from Repository to Architecture, the new text mentioned above, and the heading level changes to split up chapter 3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the moved sections into a separate file and compared them to the original. It looks like everything is still there. Approving.
Gracias, caballeros. |
This one file
repository.asciidoc
contained almost the whole spec, so I moved some of that material into an unused file that already existed, and some into a new file.I and split chapter 3 into three sections, instead of hanging everything off section 3.1.