change '#id' to 'id(this)'

[gavinking]

Since Lukas just merged my proposed change to JPQL which introduced id() and version() functions.

[gavinking]

A question I have for you guys is: should we add id(this) and version(this) as legal expressions to JPQL?

[otaviojava]

Should we have this function included before?

I mean, if the goal is to have safely contained specifications, or in this case, it is OK?

[gavinking]

Should we have this function included before?

WDYM?

[otaviojava]

Checking the Note:

Note that {@code id(this)} is the expression in JPQL for the
* unique identifier of an entity with an implicit identification
* variable.

It is a JPQL function and not a Jakarta Data Query Language function.

I remember that you taught us that the specification should be self-contained. That is, the vendor should read only this specification and understand the behavior of Jakarta Data.

We have included this JPQL function right now by note.

Should we also include this function in our query instead of referring to this JPQL query? Or is it acceptable in this case?

[gavinking]

Yeah well that's why I asked:

A question I have for you guys is: should we add id(this) and version(this) as legal expressions to JPQL?

It's not critical in this case (or at least not yet) because right now this is just a magical constant string value.

[gavinking]

at least not yet

Obviously I'm thinking toward the future here.

[njr-11]

This seems like a good forward thinking thing to do. We don't currently specify that functions can be supplied to Sort or OrderBy, but should we ever decide to add that, this would be consistent with it.

[njr-11]

A question I have for you guys is: should we add id(this) and version(this) as legal expressions to JPQL?

It seems like that could be useful, but it should be fine to wait on that until next version.

[njr-11]

I thought of another use for id(this). Assuming it can be used as follows, it could allow us to bring back BasicRepository.findByIdIn,

@Query("WHERE id(this) IN ?1 ORDER BY id(this) ASC")
List<T> findByIdIn(Iterable<K> ids);

[gavinking]

Assuming it can be used as follows, it could allow us to bring back BasicRepository.findByIdIn

That is correct.

Indeed, as far as I recall, this was the real reason I originally wanted it.