Fixes to code examples in jdoc and spec #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in section about pagination
gavinking
commented
Mar 25, 2024
| CursoredPage<Car> find(@By(_Car.make) String manufacturer, | ||
| @By(_Car.model) String model, | ||
| PageRequest<Car> pageRequest); | ||
| @Find |
There was a problem hiding this comment.
👀 was missing @Find
gavinking
commented
Mar 25, 2024
| * while (page.hasNext()) { | ||
| * page = people.inAgeRange(35, 59, | ||
| * page.nextPageRequest().withoutTotal()); | ||
| * results = page.content(); |
There was a problem hiding this comment.
👀 this code didn't even compile
njr-11
requested changes
Mar 25, 2024
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
|
I applied your suggestions. |
njr-11
approved these changes
Mar 25, 2024
otaviojava
reviewed
Mar 26, 2024
| .pageSize(10) | ||
| .afterKey(priceMidpoint, 0L); | ||
| CursoredPage<Product> moreExpensive = products.findByNameLike(pattern, pageRequest); | ||
| PageRequest<Product> pageRequest = |
There was a problem hiding this comment.
Why not include the extra space here as you did at:
https://github.com/jakartaee/data/pull/590/files#diff-451947eabf993881db66ea833734022a76dff66ae9b0d26c2417e187fa3932acR1520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.