TCK tests for literals in query language #592
Conversation
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Ah, nice catch, I missed that (Hibernate does not require the class name). |
|
Then the grammar needs to change too: |
…ded to grammar
Thanks for pointing that out. I added it to this commit. |
| @@ -70,11 +71,17 @@ Stream<AsciiCharacter> findByHexadecimalIgnoreCaseBetweenAndHexadecimalNotIn(Str | |||
|
|
|||
| Optional<AsciiCharacter> findFirstByHexadecimalStartsWithAndIsControlOrderByIdAsc(String firstHexDigit, boolean isControlChar); | |||
|
|
|||
| @Query("WHERE hexadecimal <> ' ORDER BY isn''t a keyword when inside a literal' AND hexadecimal IN ('4a', '4b', '4c', ?1)") | |||
There was a problem hiding this comment.
If it is verified at build time, it might not compile.
There was a problem hiding this comment.
If it is verified at build time, it might not compile.
Can you explain why and where the error is? As best I can see, the query language used is consistent with what is defined in the spec here. A user can write this query and they will expect it to work, per the spec.
There was a problem hiding this comment.
Never mind.
Remember that JPA Buddy does this validation at the build time and while you are coding; however, this is not a JPA provider but a plugin.
Add TCK tests for literals defined by the Jakarta Data Query Language.
While testing this, I noticed that we did not comply with Jakarta Persistence 3.2 M2 specification regarding how enum literals and so I fixed that as well.