Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Order.by(List) #606

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Add Order.by(List) #606

merged 1 commit into from
Mar 30, 2024

Conversation

gavinking
Copy link
Contributor

These are convenience methods, but useful ones.

njr-11
njr-11 requested changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order.by(List<Sort>) seems fine, but I'm unclear on the benefit of the other methods

api/src/main/java/jakarta/data/page/Pagination.java Outdated Show resolved Hide resolved
api/src/main/java/jakarta/data/page/PageRequest.java Outdated Show resolved Hide resolved
@gavinking gavinking changed the title Two optimizations to the API Add Order.by(List) Mar 29, 2024
@gavinking
Copy link
Contributor Author

I'm unclear on the benefit of the other methods

I have now dropped the commits which added those two methods.

njr-11
njr-11 approved these changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@otaviojava otaviojava merged commit 875359e into jakartaee:main Mar 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswatosh mswatosh mswatosh left review comments

@njr-11 njr-11 njr-11 approved these changes

@otaviojava otaviojava Awaiting requested review from otaviojava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gavinking @njr-11 @mswatosh @otaviojava