Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test, which was added yesterday, requires dynamically sorting by fields which are not
select
ed. As far as I know, the specification does not explicitly require this, and in traditional SQL, sorting by unselected fields is something that is not usually considered allowed, though it's true that many databases are quite forgiving here.Now, it's true that I didn't disallow this in JDQL, but there's a big difference between allowing it statically and allowing it for dynamically-added sorting.
Actually I probably should have disallowed it in JDQL, because in fact JPQL disallows it in section 4.10 of the latest Persistence spec. (Again, actually-existing JPQL implementations do allow it.) I will follow up with a PR that adds a caveat about this to section 5.5.5.
Folks, I think at this late stage we should try hard to avoid adding "weird" new corner-casey things like this to the TCK. Let's stick to bread-and-butter things which we know are supposed to work and leave stuff like this alone for now.