copy information from module-info to spec #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also remove some weird statements about Jakarta Persistence being limited to int
gavinking
force-pushed
the
qmn-return-types
branch
from
57ac09a
to
796c0fe
Compare
njr-11
approved these changes
Apr 4, 2024
| @@ -636,15 +636,15 @@ | |||
| * <tr style="vertical-align: top; background-color:#eee"><td>{@code countBy...}</td> | |||
| * <td>{@code long}, | |||
| * <br>{@code int}</td> | |||
| * <td>Jakarta Persistence providers limit the maximum to {@code Integer.MAX_VALUE}</td></tr> | |||
There was a problem hiding this comment.
I know I wrote these statements at one point, and I thought I remember doing so in response to limitations that I found in the Jakarta Persistence spec but I cannot find it now, and in any case, it doesn't make any sense to me why the language was on methods that are returning counts rather than find methods that return lists of results, which seems the more likely place to encounter limits.
There was a problem hiding this comment.
Ah, right, well it's true that a Java List or array can only have MAX_INTEGER elements, but that's not specific to Jakarta Persistence. Anyway, that many entities in memory will definitely blow up your computer.
otaviojava
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information about Query by Method Name return types should be in the spec (by value, not by reference).
I have also taken the liberty to remove some weird statements about Jakarta Persistence being limited to
Integer.MAX_VALUE. To be clear, the type of thecount()function in JPQL islong.