give cursor TCK tests a meaningful page number rather than defaulting to 1 #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…ther than defaulting to 1 Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11
force-pushed
the
670-specify-more-meaningful-page-number-in-TCK-tests
branch
from
e7c00e3
to
9848ae0
Compare
|
OK, perfect! Now we're down to one lonely TCK test failure on our end. That last one is something weird that's going to require debugging, but I doubt it's a bug in our implementation. |
gavinking
approved these changes
Apr 8, 2024
|
With this change, we now pass the TCK: 
|
|
Wait, I might have celebrated too soon. I think there's more tests that Scott has not wired in yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #670