more improvements to the presentation of the QbMN feature #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
requested review from
otaviojava and
njr-11
and removed request for
otaviojava
njr-11
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
This looks good. I identified a few places to switch "may" or "should" to "must". It looks like we were both working on Query by Method Name documentation at the exact same time here, but fortunately all of your updates are in the spec document and all of mine are in the javadoc so we managed to completely avoid merge conflicts.
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no semantic changes here.