Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic module name to the implementation jar #147

Closed
Thihup opened this issue Dec 20, 2020 · 0 comments · Fixed by #148
Closed

Add automatic module name to the implementation jar #147

Thihup opened this issue Dec 20, 2020 · 0 comments · Fixed by #148

Comments

@Thihup
Copy link
Contributor

Thihup commented Dec 20, 2020

Using the version 3.x, we could require jakarta.el in the module-info and it worked because it was both the implementation and the API.

Now in version 4.0.0, the automatic module name of the API in the manifest is jakarta.el. However, the implementation jar is the same name and doesn't contain the automatic module name in the manifest, so both end up having the same automatic module name and thus not being able to require the API and the implementation.

Trying to run both jars in module-path gives use the following error:

java.lang.module.FindException: Two versions of module jakarta.el found in lib (jakarta.el-api-4.0.0.jar and jakarta.el-4.0.0.jar)

Probably adding an automatic module name for the implementation should be enough.

Related: jakartaee/pages#197

@Thihup Thihup changed the title Add automatic module name for the implementation jar Add automatic module name to the implementation jar Dec 21, 2020
arjantijms added a commit that referenced this issue Dec 21, 2020
Fixes #147 - Add automatic module name to the implementation jar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant