Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faces 4.0: rename "jsf" throughout source code to "faces" #1552

Closed
BalusC opened this issue Jan 31, 2021 · 12 comments
Closed

Faces 4.0: rename "jsf" throughout source code to "faces" #1552

BalusC opened this issue Jan 31, 2021 · 12 comments
Milestone

Comments

@BalusC
Copy link
Member

BalusC commented Jan 31, 2021

"JSF" throughout source code must be renamed to "Jakarta Faces" or at least "Faces". No abbreviations.

For JavaScript:

  • Rename jsf.js file to faces.js
  • Rename window.jsf variable to window.faces (so jsf.util.*, jsf.ajax.*, jsf.push.* become faces.util.*, faces.ajax.*, faces.push.*)

For JNDI:

  • Rename jsf/ClientSideSecretKey to faces/ClientSideSecretKey
  • Rename jsf/FlashSecretKey to faces/FlashSecretKey

For passthrough elements:

  • Rename xmlns:jsf to xmlns:faces.
  • Advocate new namespace prefix in documentation (e.g. "such as <input type="text" jsf:id >" must become "such as <input type="text" faces:id >"

For log strings:

  • Rename key jsf.* to faces.*
  • Rename text "JSF" to "Faces"

For impl:

  • Rename com.sun.faces.facelets.tag.jsf package to com.sun.faces.facelets.tag.faces
  • Rename Jsf / JSF / jsf in method/variable/class names to Faces / Faces / faces
  • Rename mojarra.jsfcljs to mojarra.cljs

Doubts:

@tandraschko
Copy link

+1

@BalusC BalusC changed the title Faces 4.0: rename jsf.js and window.jsf Faces 4.0: rename "jsf" throughout source code to "faces" Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Feb 21, 2021
@BalusC
Copy link
Member Author

BalusC commented Feb 22, 2021

PR created in Mojarra project: eclipse-ee4j/mojarra#4833

@arjantijms arjantijms added the 4.0 label Mar 27, 2021
@arjantijms arjantijms added this to the 4.0 milestone Mar 27, 2021
@BalusC BalusC closed this as completed Mar 27, 2021
@tandraschko
Copy link

@BalusC FacesConfig.java still uses JSF

@tandraschko
Copy link

tandraschko commented Apr 12, 2021

and what should we do about jsfc?
just find a good name for it? maybe something like faces:component="h:outputText"

@tandraschko
Copy link

and +1 to delete PreJsf2ExceptionHandlerFactory

@tandraschko
Copy link

ResourceHandler also still contains "JSF_" vars
i think we should rename all

@BalusC
Copy link
Member Author

BalusC commented Apr 12, 2021

  • FacesConfig: I didn't rename it because there was a pending ticket to remove it
  • jsfc is basically superseded by passthrough elements, I think we better just remove it to keep things simple and unambiguous
  • PreJsf2ExceptionHandlerFactory will be deprecated
  • ResourceHandler constants were indeed overlooked, the old ones should be deprecated and new ones should be added

@BalusC BalusC reopened this Apr 12, 2021
@tandraschko
Copy link

  1. all right
  2. it is ok for me but jsfc has a powerful feature to map e.g. "input" to "p:inputText". So one can use plain html and map them to PF via a single attribute. quite nice.
  3. Really just deprecate PreJsf2ExceptionHandlerFactory? Never seens anyone uses it since 10 years JSF ;D
  4. +1

@arjantijms
Copy link
Contributor

it is ok for me but jsfc has a powerful feature

If I'm not mistaken, "jsfc" originally came in by accident. Both Mojarra and MyFaces essentially copied in Jackob's Facelet code, and it just had the "jsfc" attribute, even though it wasn't specified or anything.

Maybe if it becomes "component" we could take the opportunity to specify it better (if still needed).

@BalusC
Copy link
Member Author

BalusC commented Apr 12, 2021

  1. We still need to retrofit @FacesConfig. Change API description, deprecate the Version, etc. Better create new ticket for focused discussion or reopen existing from manorrock.
  2. I'll leave it as-is for now. Better create new ticket for focused discussion.
  3. Alright, I'll just completely remove it! Completely remove PreJsf2ExceptionHandlerFactory eclipse-ee4j/mojarra#4907
  4. Done: Rename ResourceHandler constants eclipse-ee4j/mojarra#4908

@tandraschko
Copy link

tandraschko commented Apr 13, 2021

3 + 4 also fixed in MyFaces
i think we can close this now

@BalusC
Copy link
Member Author

BalusC commented Apr 14, 2021

👍

@BalusC BalusC closed this as completed Apr 14, 2021
DmitriGit added a commit to hussainnm/jakartaee-tutorial that referenced this issue Feb 7, 2022
… JSF to Faces over all place. 'jsf.js JavaScript file was renamed to faces.js' (jakartaee/faces#1552)

Signed-off-by: Dmitri Cherkas <dmitricerkas@yahoo.com>
arjantijms added a commit to eclipse-ee4j/jakartaee-tutorial that referenced this issue Feb 7, 2022
Porting Jakarta EE Tutorial from '9.1' to '10'. Jakarta Faces. Rename JSF to Faces over all place. 'jsf.js JavaScript file was renamed to faces.js' (jakartaee/faces#1552)
DmitriGit added a commit to hussainnm/jakartaee-tutorial that referenced this issue Feb 8, 2022
… JSF to Faces over all place. 'jsf.ajax.* become faces.ajax.*' (jakartaee/faces#1552)

Signed-off-by: Dmitri Cherkas <dmitricerkas@yahoo.com>
DmitriGit added a commit to hussainnm/jakartaee-tutorial that referenced this issue Feb 8, 2022
… JSF to Faces over all place. 'jsf.push.* become faces.push.*' (jakartaee/faces#1552)

Signed-off-by: Dmitri Cherkas <dmitricerkas@yahoo.com>
arjantijms added a commit to eclipse-ee4j/jakartaee-tutorial that referenced this issue Feb 11, 2022
Porting Jakarta EE Tutorial from '9.1' to '10'. Jakarta Faces. Rename JSF to Faces over all place. 'jsf.ajax.* and jsf.push.* become faces.ajax.* and faces.push.*' (jakartaee/faces#1552)
arjantijms added a commit to eclipse-ee4j/jakartaee-tutorial that referenced this issue Feb 17, 2022
Porting Jakarta EE Tutorial from '9.1' to '10'. Jakarta Faces. Faces 4.0: rename "jsf" throughout source code to "faces". Rename xmlns:jsf to xmlns:faces. Advocate new namespace prefix in documentation (e.g. "such as <input type="text" jsf:id >" must become "such as <input type="text" faces:id >" (jakartaee/faces#1552)
arjantijms added a commit to eclipse-ee4j/jakartaee-tutorial that referenced this issue Mar 4, 2022
Porting Jakarta EE Tutorial from '9.1' to '10'. Jakarta Faces. Faces 4.0: "Rename Jsf / JSF / jsf in method/variable/class names to Faces / Faces / faces" (jakartaee/faces#1552)
bohmber added a commit to bohmber/myfaces-tobago that referenced this issue Dec 12, 2022
bohmber added a commit to bohmber/myfaces-tobago that referenced this issue Dec 12, 2022
bohmber added a commit to apache/myfaces-tobago that referenced this issue Dec 12, 2022
* feat: Jakarta Faces 4.0: Rename “JSF” to “Faces”
jakartaee/faces#1552

* feat: Jakarta Faces 4.0: Rename “JSF” to “Faces”
jakartaee/faces#1552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants