Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom FacesMessage Severities #1577

Open
commodis opened this issue Aug 31, 2021 · 6 comments
Open

Allow custom FacesMessage Severities #1577

commodis opened this issue Aug 31, 2021 · 6 comments
Milestone

Comments

@commodis
Copy link

There was once an issue regarding the Severity SUCCESS (#895 or javaee/javaserverfaces-spec#895) which was just closed for no documented reason.

Even though the class jakarta.faces.application.FacesMessage$Severity is public,
its constructor is private which disallows an instantiation.

@arjantijms
Copy link
Contributor

Something in scope of 4.0 for sure. It was likely accidentally closed, as there were so many open issues then.

@thatsIch
Copy link

thatsIch commented Jun 5, 2024

I guess it did not make the cut for 4.0 😄

@BalusC
Copy link
Member

BalusC commented Jun 15, 2024

That'll be 5.0 then. This is indeed not an uncommon community demand.

@BalusC BalusC added this to the 5.0 milestone Jun 15, 2024
@tandraschko
Copy link

@BalusC @arjantijms i think we can either do this or #1934

@commodis
Copy link
Author

commodis commented Jul 8, 2024

An enum would not be extensible.
If this is implemented as an enum then the only business requirement I have is to add the SUCCESS.
It seems MyFaces has already implemented it (#1592).

This is also seen in PrimeNG that this is commonly available (https://www.primefaces.org/primeng-v8-lts/#/messages).

If Mojarra also implements SUCCESS this issue here can be retracted.

@tandraschko
Copy link

then i would prefer a ENUM over this ticket as we already have SUCCESS and this was the only requested severity since years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants