Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new FacesMessage Severity "SUCCESS" #1592

Open
chsreedhar opened this issue Apr 30, 2020 · 7 comments
Open

Add new FacesMessage Severity "SUCCESS" #1592

chsreedhar opened this issue Apr 30, 2020 · 7 comments
Labels
myfaces-implemented API issue implemented by MyFaces
Milestone

Comments

@chsreedhar
Copy link

Adding a "success" severity for FacesMessages sounds like a good idea to me.

There is an issue of JavaServer Faces Add new FacesMessage Severity "SUCCESS" eclipse-ee4j/mojarra#895 and it is closed.

FacesMessages, <b:messages /> & <b:message /> eclipse-ee4j/mojarra#1000

@elasticondo
Copy link

This would be a good first stepping stone, before allowing custom faces messages.

@arjantijms arjantijms transferred this issue from eclipse-ee4j/mojarra Nov 27, 2021
@tandraschko tandraschko added this to the 4.1 milestone Feb 23, 2023
@tandraschko
Copy link

would like to do this for 4.1; easy and good enhancement

@BalusC
Copy link
Member

BalusC commented Feb 23, 2023

+1 for the idea.

Put it between INFO and WARN.

Bump of ordinals of WARN and higher will however affect backwards compatibility on those who are comparing them with hardcoded integers.

Nonetheless, I also strongly feel like we should migrate the whole Severity class to a normal enum. The same for PhaseId. Is there more? This is better to be done in 5.0 rather than 4.1.

@tandraschko
Copy link

+1 for enums

@tandraschko
Copy link

move to 5.0 and refactor to enum

@tandraschko
Copy link

tandraschko commented Jun 26, 2024

will only handle the new sucess here and moved the enum change to a own ticket

@tandraschko tandraschko added the myfaces-implemented API issue implemented by MyFaces label Jun 26, 2024
@tandraschko
Copy link

See: apache/myfaces@3b69013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
myfaces-implemented API issue implemented by MyFaces
Projects
None yet
Development

No branches or pull requests

4 participants