Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unused PreDestroyCustomScopeEvent and PostConstructCustomScopeEvent #1707

Closed
pnicolucci opened this issue Oct 21, 2022 · 9 comments
Closed

Deprecate unused PreDestroyCustomScopeEvent and PostConstructCustomScopeEvent #1707

pnicolucci opened this issue Oct 21, 2022 · 9 comments
Labels
mojarra-implemented API issue implemented by Mojarra myfaces-implemented API issue implemented by MyFaces
Milestone
4.1

Comments

@pnicolucci
Copy link
Contributor

https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/event/postconstructcustomscopeevent

https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/event/predestroycustomscopeevent

The only use I know of was for the CustomScoped annotation which has now been removed in Faces 4.0.

In addition is there any use case for: https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/event/scopecontext post Faces 4.0?
@tandraschko
Copy link

tandraschko commented Oct 21, 2022 via email

@tandraschko tandraschko added this to the 4.1 milestone Nov 15, 2022
@tandraschko tandraschko changed the title Should PreDestroyCustomScopeEvent and PostConstructCustomScopeEvent be removed in the next Faces release? Remove unused PreDestroyCustomScopeEvent and PostConstructCustomScopeEvent Feb 25, 2023
@BalusC
Copy link
Member

BalusC commented Jul 22, 2023

We can only mark it @Deprecated in 4.1 and then remove it in 5.0.

BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Jul 22, 2023
@BalusC
https://github.com/jakartaee/faces/issues/1707
a18d500 
deprecate custom scope events which are unused since 4.0
@BalusC BalusC mentioned this issue Jul 22, 2023
Merged
@tandraschko tandraschko changed the title Remove unused PreDestroyCustomScopeEvent and PostConstructCustomScopeEvent Deprecate unused PreDestroyCustomScopeEvent and PostConstructCustomScopeEvent Jul 25, 2023
@tandraschko tandraschko added the myfaces-implemented API issue implemented by MyFaces label Jul 25, 2023
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Jul 29, 2023
@BalusC
Merged 4.1 into 5.0
d041e57 
jakartaee/faces#1712
jakartaee/faces#1828
jakartaee/faces#1821
jakartaee/faces#1823
jakartaee/faces#1707
@BalusC BalusC added the mojarra-implemented API issue implemented by Mojarra label Jul 30, 2023
@BalusC BalusC closed this as completed Jul 30, 2023
@BalusC
Copy link
Member

BalusC commented Sep 2, 2023

Reopening. @pnicolucci said we cannot deprecate things in a minor version. So I've reverted it in Mojarra. We can only deprecate it in 5.0 and then remove in 6.0.

@BalusC BalusC reopened this Sep 2, 2023
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Sep 2, 2023
@BalusC
Revert "jakartaee/faces#1707 deprecate custom
2ac516a 
scope events which are unused since 4.0"

This reverts commit a18d500.
@pnicolucci
Copy link
Contributor Author

Reopening. @pnicolucci said we cannot deprecate things in a minor version. So I've reverted it in Mojarra. We can only deprecate it in 5.0 and then remove in 6.0.

@BalusC There is no issue with the deprecation as long as we ensure it is not removed in 5.0, see this thread for additional details: https://www.eclipse.org/lists/faces-dev/msg00328.html

@volosied
Copy link
Contributor

Just as with composite:extension, I'll try to have this brought up in one of the upcoming Jakarta Platform calls to get approval to have this removed without deprecation.

As Paul mentioned, it looks to be used with jakarta.faces.bean.CustomScoped and JSF Managed Beans which were removed in 4.0.

Best to removed rather than wait until Faces 6.0 to remove.

BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Sep 16, 2023
@BalusC
Revert "Revert "jakartaee/faces#1707 deprecate
a22c77c 
custom scope events which are unused since 4.0""

This reverts commit 2ac516a.
@BalusC
Copy link
Member

BalusC commented Sep 16, 2023

Ok, I misunderstood.

I reverted the revert.

@edburns
Copy link

edburns commented Sep 19, 2023

Discussed at 2023-09-19 Platform Project meeting:
These three would have been removed in Faces 4.1. The recently approved deprecation process does indeed cover this kind of case.
Emily observed

  • The spec committee needs to grant this exception.
  • Will bring this up at the next spec committee meeting, with the understanding this is pre-approved.
  • It is a wasted effort to do 4.1 to accommodate these changes.

@BalusC
Copy link
Member

BalusC commented Oct 5, 2023

Implemented in both Mojarra and MyFaces, closing off.

@BalusC BalusC closed this as completed Oct 5, 2023
@BalusC BalusC mentioned this issue Nov 4, 2023
Closed
@BalusC
Copy link
Member

BalusC commented Nov 4, 2023 •
edited
Loading

Re-reading the "would have been removed", are you saying that it's totally fine to remove these without deprecation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mojarra-implemented API issue implemented by Mojarra myfaces-implemented API issue implemented by MyFaces
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
5 participants
@edburns @BalusC @tandraschko @volosied @pnicolucci