Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify behavior of h:outputText and h:inputText #585

Closed
eclipse-faces-bot opened this issue Jul 8, 2009 · 20 comments
Closed

Specify behavior of h:outputText and h:inputText #585

eclipse-faces-bot opened this issue Jul 8, 2009 · 20 comments

Comments

@eclipse-faces-bot
Copy link

The behavior of h:outputText and h:inputText for rendering children is currently
unspecified.

The RI behavior for outputText is odd - it renders the children first, then the
value of the tag.

After extensive discussion in the EG, there was a rough consensus that children
for outputText not be rendered. During the process of implementing the fix, I
discovered that inputText had a similar undesired behavior, and also changed
that to not be rendered.

I've marked this P1, since this is slated for inclusion in the very next MR of
JSF, and the RI has already changed behavior to not render children.

Environment

Operating System: All
Platform: All

Affected Versions

[2.0]

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Reported by driscoll

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
Move to unscheduled target milestone

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
Prepare to delete api subcomponent

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
rogerk said:
cat1

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
rk

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
2.0 rev a

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
rogerk said:
The RI has added a configuration option to enable the rendering of children.
See: https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1154
And, by default, the rendering of children should not be done.
Currently, the renderkit docs for text rendering say:

"This component is responsible for rendering its children."

I suppose we could add a clarification like:

"Implementations may choose to disable the rendering of children by default."

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
rogerk said:
Ownership

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
These are valid 2.0 Rev a issues

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:

  • move to 2.1. When you do fix it, you can use this as the log message
    text.

  • modify javax.faces. {Output,Input}

    javax.faces.Text renderer to not
    render children by default, but do allow the possibility of a config
    option to control rendering.

About to attach patch.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
Created an attachment (id=232)
Fix for this bug, first iteration

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
File: diffs.txt
Attached By: @edburns

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
rogerk said:
triage

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
Change target milestone.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
rogerk said:
triage

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
Committed to trunk.

Sending jsf-api/doc/standard-html-renderkit-base.xml
Sending jsf-api/doc/standard-html-renderkit.xml
Sending jsf-api/src/main/java/javax/faces/context/ExternalContextWrapper.java
Sending jsf-api/src/main/java/javax/faces/webapp/FacesServlet.java
Sending jsf-api/src/main/resources/overview.html
Sending jsf-tools/src/main/resources/com/sun/faces/generate/facesdoc/stylesheet.css
Transmitting file data ......
Committed revision 9144.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Marked as fixed on Thursday, June 9th 2011, 1:53:46 am

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@manfredriem said:
Closing resolved issue out

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-585

@eclipse-faces-bot
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant