Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Specify behavior of h:outputText and h:inputText #585

Closed
glassfishrobot opened this issue Jul 8, 2009 · 19 comments
Closed

Specify behavior of h:outputText and h:inputText #585

glassfishrobot opened this issue Jul 8, 2009 · 19 comments

Comments

@glassfishrobot
Copy link

The behavior of h:outputText and h:inputText for rendering children is currently
unspecified.

The RI behavior for outputText is odd - it renders the children first, then the
value of the tag.

After extensive discussion in the EG, there was a rough consensus that children
for outputText not be rendered. During the process of implementing the fix, I
discovered that inputText had a similar undesired behavior, and also changed
that to not be rendered.

I've marked this P1, since this is slated for inclusion in the very next MR of
JSF, and the RI has already changed behavior to not render children.

Environment

Operating System: All
Platform: All

Affected Versions

[2.0]

@glassfishrobot
Copy link
Author

Reported by driscoll

@glassfishrobot
Copy link
Author

@edburns said:
Move to unscheduled target milestone

@glassfishrobot
Copy link
Author

@edburns said:
Prepare to delete api subcomponent

@glassfishrobot
Copy link
Author

rogerk said:
cat1

@glassfishrobot
Copy link
Author

@edburns said:
rk

@glassfishrobot
Copy link
Author

@edburns said:
2.0 rev a

@glassfishrobot
Copy link
Author

rogerk said:
The RI has added a configuration option to enable the rendering of children.
See: https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1154
And, by default, the rendering of children should not be done.
Currently, the renderkit docs for text rendering say:

"This component is responsible for rendering its children."

I suppose we could add a clarification like:

"Implementations may choose to disable the rendering of children by default."

@glassfishrobot
Copy link
Author

rogerk said:
Ownership

@glassfishrobot
Copy link
Author

@edburns said:
These are valid 2.0 Rev a issues

@glassfishrobot
Copy link
Author

@edburns said:

  • move to 2.1. When you do fix it, you can use this as the log message
    text.

  • modify javax.faces. {Output,Input}

    javax.faces.Text renderer to not
    render children by default, but do allow the possibility of a config
    option to control rendering.

About to attach patch.

@glassfishrobot
Copy link
Author

@edburns said:
Created an attachment (id=232)
Fix for this bug, first iteration

@glassfishrobot
Copy link
Author

File: diffs.txt
Attached By: @edburns

@glassfishrobot
Copy link
Author

rogerk said:
triage

@glassfishrobot
Copy link
Author

@edburns said:
Change target milestone.

@glassfishrobot
Copy link
Author

rogerk said:
triage

@glassfishrobot
Copy link
Author

@edburns said:
Committed to trunk.

Sending jsf-api/doc/standard-html-renderkit-base.xml
Sending jsf-api/doc/standard-html-renderkit.xml
Sending jsf-api/src/main/java/javax/faces/context/ExternalContextWrapper.java
Sending jsf-api/src/main/java/javax/faces/webapp/FacesServlet.java
Sending jsf-api/src/main/resources/overview.html
Sending jsf-tools/src/main/resources/com/sun/faces/generate/facesdoc/stylesheet.css
Transmitting file data ......
Committed revision 9144.

@glassfishrobot
Copy link
Author

Marked as fixed on Thursday, June 9th 2011, 1:53:46 am

@glassfishrobot
Copy link
Author

@manfredriem said:
Closing resolved issue out

@glassfishrobot
Copy link
Author

This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-585

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants