Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IT for https://github.com/eclipse-ee4j/mojarra/issues/5078 #1658

Merged
merged 2 commits into from
Apr 24, 2022
Merged

Add IT for https://github.com/eclipse-ee4j/mojarra/issues/5078 #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ddeea1
Add IT for https://github.com/eclipse-ee4j/mojarra/issues/5078
BalusC Apr 24, 2022
6bccf61
Remove test stdout
BalusC Apr 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...3/facelets/src/main/java/ee/jakarta/tck/faces/test/servlet40/facelets/CollectionBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,19 @@
@RequestScoped
public class CollectionBean {

private Integer value;

public Collection<Integer> getCollection() {
return new TestCollection<>(asList(1, 2, 3));
}

public Integer getValue() {
return value;
}

public void setValue(Integer value) {
this.value = value;
}

private static class TestCollection<E> extends AbstractCollection<E> {

Expand Down
40 changes: 40 additions & 0 deletions tck/faces23/facelets/src/main/webapp/issue5078.xhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<!DOCTYPE html>
<!--

Copyright (c) 1997, 2018 Oracle and/or its affiliates. All rights reserved.

This program and the accompanying materials are made available under the
terms of the Eclipse Public License v. 2.0, which is available at
http://www.eclipse.org/legal/epl-2.0.

This Source Code may also be made available under the following Secondary
Licenses when the conditions for such availability set forth in the
Eclipse Public License v. 2.0 are satisfied: GNU General Public License,
version 2 with the GNU Classpath Exception, which is available at
https://www.gnu.org/software/classpath/license.html.

SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0

-->

<html lang="en"
xmlns="http://www.w3.org/1999/xhtml"
xmlns:f="http://xmlns.jcp.org/jsf/core"
xmlns:h="http://xmlns.jcp.org/jsf/html"
xmlns:ui="http://xmlns.jcp.org/jsf/facelets">

<h:head>
<title>Issue5078IT - UIRepeat#visitTree() should not clear out var/varStatus when invoked during invoke application</title>
</h:head>
<h:body>
<h:form id="form">
<ui:repeat id="repeat" value="#{collectionBean.collection}" var="value">
<h:outputText value="#{value} " />
<h:commandButton id="button" value="button" action="#{collectionBean.setValue(value)}">
<f:ajax execute="@this" render="@form" />
</h:commandButton>
</ui:repeat>
<h:outputText id="value" value="#{collectionBean.value}" />
</h:form>
</h:body>
</html>
51 changes: 51 additions & 0 deletions ...es23/facelets/src/test/java/ee/jakarta/tck/faces/test/servlet40/facelets/Issue5078IT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
/*
* Copyright (c) 1997, 2018 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020 Contributors to Eclipse Foundation.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
* http://www.eclipse.org/legal/epl-2.0.
*
* This Source Code may also be made available under the following Secondary
* Licenses when the conditions for such availability set forth in the
* Eclipse Public License v. 2.0 are satisfied: GNU General Public License,
* version 2 with the GNU Classpath Exception, which is available at
* https://www.gnu.org/software/classpath/license.html.
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
*/

package ee.jakarta.tck.faces.test.servlet40.facelets;

import static org.junit.Assert.assertEquals;

import org.jboss.arquillian.junit.Arquillian;
import org.junit.Test;
import org.junit.runner.RunWith;

import com.gargoylesoftware.htmlunit.html.HtmlPage;
import com.gargoylesoftware.htmlunit.html.HtmlSubmitInput;

import ee.jakarta.tck.faces.test.util.arquillian.ITBase;
import jakarta.faces.component.UIComponent;
import jakarta.faces.component.UIViewRoot;

@RunWith(Arquillian.class)
public class Issue5078IT extends ITBase {

/**
* @see com.sun.faces.facelets.component.UIRepeat
* @see UIComponent#visitTree(jakarta.faces.component.visit.VisitContext, jakarta.faces.component.visit.VisitCallback)
* @see UIViewRoot#processApplication(jakarta.faces.context.FacesContext)
* @see https://github.com/eclipse-ee4j/mojarra/issues/5078
*/
@Test
public void testUIRepeatResetValues() throws Exception {
HtmlPage page = getPage("faces/issue5078.xhtml");
HtmlSubmitInput button = (HtmlSubmitInput) page.getHtmlElementById("form:repeat:1:button");
page = button.click();
webClient.waitForBackgroundJavaScript(60000);
assertEquals("2", page.getHtmlElementById("form:value").asNormalizedText());
}

}