Add Manifest data to API jar #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clone the maven-bundle-plugin config from impl and modify for the API artifact
pzygielo
reviewed
Jul 8, 2022
| <!-- Generate the OSGi jar Manifest. --> | ||
| <plugin> | ||
| <groupId>org.apache.felix</groupId> | ||
| <artifactId>maven-bundle-plugin</artifactId> |
There was a problem hiding this comment.
I'm getting
[WARNING] 'build.plugins.plugin.version' for org.apache.felix:maven-bundle-plugin is missing. @ line 290, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
There was a problem hiding this comment.
If version 5.1.6 is to be used (the latest) note that it needs 2 extra instructions to prevent it from creating a corrupted jar:
<instructions>
<_noimportjava>true</_noimportjava>
<_runee>JavaSE-11</_runee>
</instructions>There was a problem hiding this comment.
Sorry. It ran fine on my machine without that, so I was unaware of the need here. :)
BalusC
reviewed
Jul 8, 2022
api/pom.xml
Outdated
| <Specification-Version>4.0</Specification-Version> | ||
| <!-- Set the package version to match the spec version --> | ||
| <Export-Package> | ||
| javax.faces*;version=4.0 |
There was a problem hiding this comment.
Should be jakarta.* of course.
dmatej
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone the maven-bundle-plugin config from impl and modify for the API artifact