Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a session to avoid NPE reported in PR 1738 #1769

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

volosied
Copy link
Contributor

@volosied volosied commented Dec 13, 2022

NPE introduced in 1738. See discussion here: #1738 (comment)

Open Liberty encounters an NPE as no session exists in this test yet. The session implicit object therefore returns null.

Caused by: java.lang.NullPointerException: 
at com.sun.ts.tests.jsf.spec.el.elresolvers.TestServlet.validateImplicitObjectValue(TestServlet.java:1566)
at com.sun.ts.tests.jsf.spec.el.elresolvers.TestServlet.facesImplicitObjectResolverGetValueTest(TestServlet.java:615)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Or should the session only be created for the session implicit part of test, and then deleted afterwards? Previously, the session was created within the getELContexts method ( by the JspFactory.getDefaultFactory().getPageContext() call)

@volosied
Copy link
Contributor Author

@arjantijms @BalusC Any objections to this change? Could it be reviewed/merged?

@pnicolucci
Copy link
Contributor

This looks reasonable to me! If no objections I can merge it in.

@volosied volosied changed the title Create a session to avoid NPE reportd in PR 1738 Create a session to avoid NPE reported in PR 1738 Jan 13, 2023
@pnicolucci pnicolucci merged commit f8195be into jakartaee:master Jan 13, 2023
@pnicolucci pnicolucci added this to the 4.0.1-TCK milestone Feb 26, 2023
@arjantijms arjantijms modified the milestones: 4.0.1-TCK, 4.0.2-TCK Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants