Smaller improvements in the Selenium Framework - Improvement of Selenium based Spec 1423 Test #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wait timeout in favor of a dom wait until condition in Spec 1423
werpu
changed the title
…ndows. Add added reduced page patterns on the 2906IT Tests
BalusC
reviewed
Feb 16, 2023
tck/util/src/main/java/ee/jakarta/tck/faces/test/util/selenium/ChromeDevtoolsDriver.java
Outdated
Show resolved
Hide resolved
|
I've tested out these new changes, and they work well for Open Liberty. We would appreciate this being included in the upcoming version of the TCK, assuming the review by @BalusC is resolved. |
BalusC
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces smaller improvements in the test framework coming from my upstream project.
By setting -Dchromedriver.headless=false you can enforce a browser window opening during test run.
Improved the end of script detection slightly (or eased an unfixable race condition inherent to Seleniums Webdriver system)
Improved the Spec 1423 Test by replacing one end of script execution wait condition in favor of a "Dom Change" wait condition!
(which should be applied wherever possible)
Fixing and improving the internal comments!
Fixed also a small issue with Issue2906IT, where due to Chrome a hidden NBSP broke the test on some test configurations (difference between Chrome and HTML Unit how to treat the sourcecode was the cause)