Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draw.io SVG images aren't rendering properly in PDFs #85

Open
kito99 opened this issue Nov 21, 2023 · 3 comments
Open

draw.io SVG images aren't rendering properly in PDFs #85

kito99 opened this issue Nov 21, 2023 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@kito99
Copy link

kito99 commented Nov 21, 2023

The SVG version of newer diagrams that were recently added (see /src/modules/intro/images and /src/modules/security/images) look fine in a browser, but don't render properly in PDF format. See: https://jakartaee.github.io/jakartaee-documentation/jakartaee-tutorial/10/jakarta-ee-tutorial.pdf. We need to figure out what it is about the images that's causing the problem. I suspect it's the fact that I saved them via the "Editable SVG" feature rather than exporting as SVG (which offers more features). Here are the details from the contribution guide that explain how they were generated:

Diagram requirements

  • Font must be 'Open Sans' conform
    the Jakarta EE Brand Usage Handbook.
    You can use Google Fonts for this.
    In case you're using draw.io:

    • Wherever you see a 'Font' dropdown, unfold it.
    • If there's no 'Open Sans' option, pick 'Custom'.
    • Choose the 'Google Fonts' option and set the font name to 'Open Sans' and apply.
    • Type text and verify that the font is Open Sans
  • Font size for all text should be 12pt

  • Color must be one of those defined
    in Jakarta EE Brand Usage Handbook,
    along with black and white (you can use opacity to affect the depth of the color).

    • Primary colors:
      • Blue: #1B208B
      • Orange: #F98200
      • Black: #3D3D3D
      • White: #FFFFFF
    • Secondary colors:
      • Yellow: #FDB940
      • Grey: #58595B
      • Dark blue: #131660
  • Arrows must be Orange (#F98200)

  • Background must be white (#FFFFFF)

NOTE: I tried changing the font to something boring like Helvetica. This worked better, but still didn't turn out right.

@kito99 kito99 added the bug Something isn't working label Nov 21, 2023
@kito99 kito99 added this to the Content Modernization milestone Nov 21, 2023
@kito99 kito99 added the help wanted Extra attention is needed label Nov 21, 2023
@kito99 kito99 added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Mar 25, 2024
@rmccrear
Copy link

Hi, I'd love to pick up this issue. @kito99

@rmccrear
Copy link

rmccrear commented Mar 28, 2024

I think I've found the issue. You have to Export as SVG. Don't just Save as... in drawio. (As you suspected.)

@kito99
Copy link
Author

kito99 commented Sep 6, 2024

@rmccrear is this one ready to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants