Skip to content

Commit

Permalink
small code cleanup
Browse files Browse the repository at this point in the history
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
  • Loading branch information
lukasj committed Feb 23, 2022
1 parent 470f1ec commit 2b5290a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 25 deletions.
6 changes: 2 additions & 4 deletions api/src/main/java/jakarta/xml/ws/RespectBindingFeature.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2005, 2020 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2005, 2022 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Distribution License v. 1.0, which is available at
Expand Down Expand Up @@ -93,9 +93,7 @@ public RespectBindingFeature(boolean enabled) {
this.enabled = enabled;
}

/**
* {@inheritDoc}
*/
@Override
public String getID() {
return ID;
}
Expand Down
9 changes: 3 additions & 6 deletions api/src/main/java/jakarta/xml/ws/soap/AddressingFeature.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2005, 2020 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2005, 2022 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Distribution License v. 1.0, which is available at
Expand Down Expand Up @@ -111,8 +111,7 @@ public final class AddressingFeature extends WebServiceFeature {
* requires WS-Addressing. If required is true, WS-Addressing headers MUST
* be present on incoming and outgoing messages.
*/
// should be private final, keeping original modifier due to backwards compatibility
protected boolean required;
private boolean required;

/**
* If addressing is enabled, this property determines if endpoint requires
Expand Down Expand Up @@ -222,9 +221,7 @@ public AddressingFeature(boolean enabled, boolean required, Responses responses)
this.responses = responses;
}

/**
* {@inheritDoc}
*/
@Override
public String getID() {
return ID;
}
Expand Down
9 changes: 3 additions & 6 deletions api/src/main/java/jakarta/xml/ws/soap/MTOMFeature.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2005, 2020 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2005, 2022 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Distribution License v. 1.0, which is available at
Expand Down Expand Up @@ -54,8 +54,7 @@ public final class MTOMFeature extends WebServiceFeature {
* as attachment.
* The value of this property MUST always be {@literal >=} 0. Default value is 0.
*/
// should be changed to private final, keeping original modifier to keep backwards compatibility
protected int threshold;
private int threshold;


/**
Expand Down Expand Up @@ -110,9 +109,7 @@ public MTOMFeature(boolean enabled, int threshold) {
this.threshold = threshold;
}

/**
* {@inheritDoc}
*/
@Override
public String getID() {
return ID;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,20 +58,16 @@ public final class W3CEndpointReference extends EndpointReference {

private final JAXBContext w3cjc = getW3CJaxbContext();

// should be changed to package private, keeping original modifier to keep backwards compatibility

/**
* Addressing namespace.
*/
protected static final String NS = "http://www.w3.org/2005/08/addressing";
static final String NS = "http://www.w3.org/2005/08/addressing";

// default constructor forbidden ...
// should be private, keeping original modifier to keep backwards compatibility

/**
* Default constructor.
*/
protected W3CEndpointReference() {
private W3CEndpointReference() {
}

/**
Expand Down Expand Up @@ -177,9 +173,6 @@ List<Element> getElements() {
return elements;
}

/**
* {@inheritDoc}
*/
@Override
public void writeTo(Result result){
try {
Expand Down

0 comments on commit 2b5290a

Please sign in to comment.