Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify side effects of JsonObjectBuilder#build #178

Closed
ivangreene opened this issue Jun 5, 2019 · 1 comment · Fixed by #312
Closed

Clarify side effects of JsonObjectBuilder#build #178

ivangreene opened this issue Jun 5, 2019 · 1 comment · Fixed by #312
Labels
2.1
Projects
JSONP 2.1

Comments

@ivangreene
Copy link

In the provided implementation, the JsonObjectBuilder#build will clear the builder. This is not mentioned in the spec so it is unclear if this is intentional
@ivangreene ivangreene mentioned this issue Jun 5, 2019
Open
@lukasj lukasj added this to To do in JSONP 2.1 Sep 19, 2021
jbescos added a commit to jbescos/jsonp that referenced this issue Oct 4, 2021
@jbescos
Clarify side effects of JsonObjectBuilder#build jakartaee#178
5debe1a 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos jbescos mentioned this issue Oct 4, 2021
Merged
jbescos added a commit to jbescos/jsonp that referenced this issue Oct 5, 2021
@jbescos
Clarify side effects of JsonObjectBuilder#build jakartaee#178
1ce021a 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos
Copy link
Member

jbescos commented Oct 6, 2021

  • TCK

@jbescos jbescos mentioned this issue Oct 6, 2021
Closed
@lukasj lukasj linked a pull request Oct 13, 2021 that will close this issue
Clarify side effects of JsonObjectBuilder#build #178 #312
Merged
lukasj pushed a commit that referenced this issue Oct 13, 2021
@jbescos @lukasj
Clarify side effects of JsonObjectBuilder#build #178
b066df0 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@lukasj lukasj moved this from To do to Done in JSONP 2.1 Oct 29, 2021
@lukasj lukasj added the 2.1 label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1
Projects
No open projects
JSONP 2.1
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify side effects of JsonObjectBuilder#build #178 jbescos/jsonp
3 participants
@lukasj @jbescos @ivangreene