Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonp tck bundle generation. #341

Merged
merged 1 commit into from
Dec 16, 2021
Merged

jsonp tck bundle generation. #341

merged 1 commit into from
Dec 16, 2021

Conversation

gurunrao
Copy link
Contributor

@gurunrao gurunrao commented Dec 10, 2021 •
edited
Loading

The PR creates tck bundle with structure as follows:

  • jsonp-tck/
  • jsonp-tck/LICENSE.md
  • jsonp-tck/artifacts/
  • jsonp-tck/artifacts/artifact-install.sh (script for installation of Artifacts to local maven repository.)
  • jsonp-tck/artifacts/jakarta.json-tck-2.1.0-SNAPSHOT.pom
  • jsonp-tck/artifacts/jakarta.json-tck-common-2.1.0-SNAPSHOT.jar
  • jsonp-tck/artifacts/jakarta.json-tck-common-2.1.0-SNAPSHOT.pom
  • jsonp-tck/artifacts/jakarta.json-tck-common-2.1.0-SNAPSHOT-sources.jar
  • jsonp-tck/artifacts/jakarta.json-tck-tests-2.1.0-SNAPSHOT.jar
  • jsonp-tck/artifacts/jakarta.json-tck-tests-2.1.0-SNAPSHOT.pom
  • jsonp-tck/artifacts/jakarta.json-tck-tests-2.1.0-SNAPSHOT-sources.jar
  • jsonp-tck/artifacts/jakarta.json-tck-tests-plugability-2.1.0-SNAPSHOT.jar
  • jsonp-tck/artifacts/jakarta.json-tck-tests-plugability-2.1.0-SNAPSHOT.pom
  • jsonp-tck/artifacts/jakarta.json-tck-tests-plugability-2.1.0-SNAPSHOT-sources.jar

#Steps to build the dist for EFTL bundle:

cd jsonp/tck/
mvn clean install -P EFTL

#Steps to build the dist for EPL bundle:

cd jsonp/tck/
mvn clean install

Signed-off-by: gurunandan.rao@oracle.com gurunandan.rao@oracle.com

@gurunrao gurunrao marked this pull request as draft December 10, 2021 06:04
@gurunrao gurunrao marked this pull request as ready for review December 10, 2021 07:14
lukasj
lukasj reviewed Dec 13, 2021
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid extra definitions of the source/javadoc plugins (unless needed for doclint:none) since they are (or can be) inherited through oss-release profile from the parent ee4j-parent

@gurunrao
jsonp bundle generation.
9682493 
Signed-off-by: gurunandan.rao@oracle.com <gurunandan.rao@oracle.com>
@gurunrao
Copy link
Contributor Author

I'd avoid extra definitions of the source/javadoc plugins (unless needed for doclint:none) since they are (or can be) inherited through oss-release profile from the parent ee4j-parent

source plugin is used for generation "*-source.jar" jars. Following files are part of TCK bundle:
jsonp-tck/artifacts/jakarta.json-tck-common-2.1.0-SNAPSHOT-sources.jar
jsonp-tck/artifacts/jakarta.json-tck-tests-2.1.0-SNAPSHOT-sources.jar
jsonp-tck/artifacts/jakarta.json-tck-tests-plugability-2.1.0-SNAPSHOT-sources.jar

@alwin-joseph alwin-joseph mentioned this pull request Dec 16, 2021
Merged
lukasj
lukasj approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (inclusion of docs can be done in an extra PR)

@lukasj lukasj merged commit 6ea9d1a into jakartaee:master Dec 16, 2021
@alwin-joseph alwin-joseph mentioned this pull request Dec 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gurunrao @lukasj