Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt #505

Closed
jmehrens opened this issue Jan 19, 2021 · 1 comment
Closed

WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt #505

jmehrens opened this issue Jan 19, 2021 · 1 comment
Assignees
@jmehrens

Comments

@jmehrens
Copy link
Contributor

jmehrens commented Jan 19, 2021 •
edited

Android uses Conscrypt for the SSL implementation. The AbstractConscryptSocket defines the getFileDescriptor$() method. Per the source code it extends SSLSocket but doesn't include an override annotation for the getFileDescriptor$() method. This implies that the method is defined in this class.

The WriteTimeoutSocket.java assumes that this method is defined in the Socket class which is incorrect for newer versions of Android. The implementation should be patched to locate the method in the wrapped socket first and test cases should be added.
@jmehrens jmehrens self-assigned this Jan 19, 2021
jmehrens added a commit to jmehrens/mail that referenced this issue Jan 20, 2021
@jmehrens
WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt jakartae…
fbb1cc1 
…e#505
jmehrens added a commit to jmehrens/mail that referenced this issue Jan 21, 2021
@jmehrens
WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt jakartae…
18f42ad 
…e#505
@jmehrens jmehrens mentioned this issue Jan 21, 2021
Merged
jmehrens added a commit to jmehrens/mail that referenced this issue Jan 21, 2021
@jmehrens
WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt jakartae…
e4274a6 
…e#505
jmehrens added a commit to jmehrens/mail that referenced this issue Jan 21, 2021
@jmehrens
WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt jakartae…
ef01143 
…e#505
jmehrens added a commit to jmehrens/mail that referenced this issue Jan 21, 2021
@jmehrens
WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt jakartae…
c2e3992 
…e#505
jmehrens added a commit that referenced this issue Jan 21, 2021
@jmehrens
WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt #505 (#507)
db4f348 
WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt #505
jmehrens added a commit that referenced this issue Jan 21, 2021
@jmehrens
WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt #505 (#507)
c6d0168 
WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt #505
(cherry picked from commit db4f348)

Conflicts:
	mail/src/test/java/com/sun/mail/util/WriteTimeoutSocketTest.java
@jmehrens
Copy link
Contributor Author

Committed to master as:
db4f348

Committed to v1.x as:
c6d0168

bvfalcon pushed a commit to bvfalcon/jakarta-mail that referenced this issue Aug 8, 2022
@jmehrens
WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt jakartae…
ce680b2 
…e#505 (jakartaee#507)

WriteTimeoutSocket::getFileDescriptor$ support for Conscrypt jakartaee#505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmehrens jmehrens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmehrens