CompactFormatter precision and surrogate pairs #528 #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jmehrens <jason_mehrens@hotmail.com>
jmehrens
commented
Mar 27, 2021
| if (v != null) { | ||
| result = s.toString().replace(s.getClassName(), v); | ||
| } else { | ||
| result = s.toString(); |
There was a problem hiding this comment.
FYI this is dead code caught by code coverage. It seems from the API docs that StackTraceElement::getClassName is non null. Other parts of the code already treat it as non-null.
lukasj
reviewed
Mar 27, 2021
lukasj
approved these changes
Mar 27, 2021
There was a problem hiding this comment.
LGTM. I don't want to merge this before 2.0.1 gets approved and out, so will do that once that happens (I have no impact on the approval itself, I can only wait).
Wrt backport to v1.x - I plan to release 1.6.7 early next week to fix awful bug there, so if you have something else you want to have there, just create PR for it. Thanks!
Signed-off-by: jmehrens <jason_mehrens@hotmail.com>
bvfalcon
pushed a commit
to bvfalcon/jakarta-mail
that referenced
this pull request
Aug 8, 2022
…ee#543) Signed-off-by: jmehrens <jason_mehrens@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #528.
The code coverage has been improved. The CompactFormatter is at 99.0% and the test is at 97.7%.
Test was modified to clean up some of the SpotBugs warnings.
When this is approved I'll backport the changed to 1.x.