StreamProvider not static and OSGi support #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbescos
force-pushed
the
serviceLoaderFix
branch
2 times, most recently
from
b70c1d1
to
6e260e2
Compare
jbescos
force-pushed
the
serviceLoaderFix
branch
from
6e260e2
to
70bebf1
Compare
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
jbescos
force-pushed
the
serviceLoaderFix
branch
from
70bebf1
to
b4cd7bb
Compare
jbescos
changed the title
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
lukasj
reviewed
Nov 2, 2021
| Class<T> clazz = null; | ||
| try { | ||
| if (classLoader == null) { | ||
| clazz = (Class<T>) Class.forName(className); |
There was a problem hiding this comment.
unchecked cast... add appropriate suppresswarnings....
lukasj
reviewed
Nov 2, 2021
lukasj
approved these changes
Nov 2, 2021
|
Causes downstream problems for Jenkins: #665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamProvider is supposed to be implemented by different implementations, and it was instanced one time in a static variable.
This could be a problem in server containers, because only one instance would exist. It could happen that it is loaded as com.sun.mail, and later an application with other implementation is deployed. In this case, this application would still use com.sun.mail.