New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert package from javax to jakarta #253
Conversation
Signed-off-by: Jonathan Coustick <jonathan.coustick@payara.fish>
Signed-off-by: Jonathan Coustick <jonathan.coustick@payara.fish>
Fixes #254 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This doesn't seem to use the new ee4j parent pom. Did you find that was unnecessary? |
It was created before new parent pom was released. Uptaking new parent pom can be done in another PR. |
Should the new version be |
I guess |
I noticed that the Jakarta EE platform spec is 8.0.0 vs 8.0 that Java EE used before, and GlassFish was now asked to move to 6.0.0, hence I wondered if the x.0.0 might be a new recommendation for version numbers. |
There were no recommendations from PMC, so IMO no changes is the right approach. If it needs to be discussed please post a question to the PMC mailing list. |
Okay, I'm not particularly in favour of the x.0.0 scheme, but was more wondering whether it was a recommendation or not. Thanks! |
Isn't semver a good versioning scheme also for Jakarta EE? Every version part would have a quite clear message: The Bad, The Good, and The Ugly 😉 |
@m0mus @arjantijms Programming artifacts, e.g., jar files full of class files, zip files containing an implementation for download, etc. always have dot-dot version numbers, even when the minor and micro numbers are zero. Specification documents have single-dot version numbers, with an optional "rev level" indicating an errata update to the document. So, if you're talking about the API jar file, it should be 3.0.0-SNAPSHOT. If you're talking about the Jakarta Messaging specification document, it should be 3.0-SNAPSHOT. If you have to fix a typo after 3.0 is released, the new version would be 3.0-RevA. (We could argue about the capitalization.) |
So what you’re saying is that the version in the Pom here should be set to 3.0.0-SNAPSHOT after all? |
yes 3.0.0-SNAPSHOT for api jars 3.0 for the spec version |
Yes. Is that still confusing? How can I describe this so it's less confusing? |
No, it's super clear. My OCD kicked in for a moment ;) |
No description provided.