-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeatable annotation for the connection factory and destination definition annotations - fix for #151 #298
Conversation
…stination definition annotations Signed-off-by:Nathan Erwin <nathan.d.erwin@gmail.com>
It really looks this is all that's needed. There's no mention about these annotations in the spec document. |
Note we do have TCK updates to do when modifying APIs:
|
@dblevins If you'll point me at the TCK, I can look into making a PR there too. I'd feel better having a test for this there too. |
@nderwin, with the TCK it's not that easy. The Messaging TCK is a part of the Jakarta EE TCK. We're going to separate it away into the Messaging project, either into this repository or into a new repository. I think it's better to wait until we do it, as we may also modernize the TCK so that it's easier to work with it. The current TCK is based on the Java Harness test framework, which is not very convenient nowadays. |
@nderwin Sounds great, Nathan. Thanks for volunteering! Fair warning the TCK is still one large suite covering all (most) specs, so it will be hard to digest and if you get anywhere you'll be one of only a handful who can grok it. That said, it's what we got, LOL :) Here is the section where the JMS tests are located: The best resource for help: Here's a similar PR for when we made EJBs Many of us are hoping we can move all those tests into a new messaging-tck repo here, but so few of us really understand the TCK at that level, so it's just hopes and dreams at this point. |
My gut instinct is we don't have the luxury to wait till after it's split out to do TCK updates. There's a significant chance splitting it out may not happen. The biggest blocker is there are so few people who understand the TCK harness. I think the more people that are brave enough to dig in as it is now, the higher the chance we can actually get it done. |
Repeatable
annotation for the connection factory and destination definition annotationsSigned-off-by:Nathan Erwin nathan.d.erwin@gmail.com