Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump maven-bundle-plugin to allow building with Java 17+ #311

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Bump maven-bundle-plugin to allow building with Java 17+ #311

merged 1 commit into from
Feb 8, 2022

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jan 30, 2022 •
edited
Loading

Currently used plugin with Java 17 gives

[INFO] --- maven-bundle-plugin:4.2.1:manifest (bundle-manifest) @ jakarta.jms-api ---
[ERROR] An internal error occurred
java.util.ConcurrentModificationException
    at java.util.TreeMap.callMappingFunctionWithCheck (TreeMap.java:750)
    at java.util.TreeMap.computeIfAbsent (TreeMap.java:604)
    at aQute.bnd.osgi.Jar.putResource (Jar.java:288)
    at aQute.bnd.osgi.Jar$1.visitFile (Jar.java:202)
    at aQute.bnd.osgi.Jar$1.visitFile (Jar.java:177)
...

@pzygielo pzygielo marked this pull request as ready for review January 30, 2022 07:59
@pzygielo
Copy link
Contributor Author

pzygielo commented Feb 8, 2022

May I ask for review, please?

arjantijms
arjantijms approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, GlassFish and many other projects did the same update.

@arjantijms arjantijms merged commit a59f98b into jakartaee:master Feb 8, 2022
@arjantijms arjantijms added this to the 3.1.0 milestone Feb 8, 2022
@pzygielo pzygielo deleted the felix branch February 8, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pzygielo @arjantijms