Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jakartafy Controllers #5

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Jakartafy Controllers #5

merged 2 commits into from
Jun 30, 2020

Conversation

ivargrimstad
Copy link
Member

Signed-off-by: Ivar Grimstad ivar.grimstad@eclipse-foundation.org

@ivargrimstad
Jakartafy Controllers
7d6454d 
Signed-off-by: Ivar Grimstad <ivar.grimstad@eclipse-foundation.org>
@ivargrimstad ivargrimstad requested a review from chkal June 29, 2020 06:49
@ivargrimstad ivargrimstad added this to the 1.1 milestone Jun 29, 2020
chkal
chkal requested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@chkal chkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I added a few comments. Some typos. And sometimes replacing JCP with Jakarta Server Pages doesn't work well, because the text actually doesn't refer to the spec, but to a JSP file.

spec/src/main/asciidoc/chapters/controllers.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/chapters/controllers.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/chapters/controllers.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/chapters/controllers.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/chapters/controllers.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/chapters/controllers.asciidoc Outdated Show resolved Hide resolved
@ivargrimstad
Fix typos
b92f0dd 
Signed-off-by: Ivar Grimstad <ivar.grimstad@eclipse-foundation.org>
@ivargrimstad ivargrimstad requested a review from chkal June 30, 2020 11:08
@ivargrimstad ivargrimstad merged commit a64c87f into jakartaee:master Jun 30, 2020
@ivargrimstad ivargrimstad deleted the mvc branch July 1, 2020 09:28
@ivargrimstad ivargrimstad mentioned this pull request Jul 11, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkal chkal Awaiting requested review from chkal

Assignees

@ivargrimstad ivargrimstad

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivargrimstad @chkal