Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote jakarta.persistence.database-xxxx config properties #628

Open
gavinking opened this issue May 14, 2024 · 2 comments
Open

promote jakarta.persistence.database-xxxx config properties #628

gavinking opened this issue May 14, 2024 · 2 comments
Labels
candidate-for-4 Good candidate for JPA 4

Comments

@gavinking
Copy link
Contributor

The configuration properties jakarta.persistence.database-product-name, jakarta.persistence.database-major-version, and jakarta.persistence.database-minor-version are currently defined as part of the container/provider contract.

But these properties are generally-useful as a way of configuring the persistence provider when access to JDBC metadata is not available at startup time (for example, in Quarkus, or in some cloud environments). And so Hibernate has never treated them as specific to container-based configuration.

We should promote these to the same status as other application-settable config properties, and add them to PersistenceConfiguration.

@quaff
Copy link

quaff commented May 27, 2024

Hibernate will use jakarta.persistence.database-xxxx for resolving dialect but EclipseLink will not, the specification only mention them for configuring the schema generation process, I think it should promoted too.

@gavinking
Copy link
Contributor Author

Yes, exactly, that's what I'm trying to say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate-for-4 Good candidate for JPA 4
Projects
None yet
Development

No branches or pull requests

2 participants