Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review spring.jpa.database and spring.jpa.database-platform and their standard JPA equivalents #40910

Open
quaff opened this issue May 27, 2024 · 4 comments
Open

Review spring.jpa.database and spring.jpa.database-platform and their standard JPA equivalents #40910

quaff opened this issue May 27, 2024 · 4 comments
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Milestone
3.5.x

Comments

@quaff
Copy link
Contributor

quaff commented May 27, 2024 •
edited
Loading

Different versions of same database platform behave differently, database-platform is not enough to choose the most precise dialect, it should combines with major-version and minor-version, we should migrate to standard JPA properties:

  • jakarta.persistence.database-product-name
  • jakarta.persistence.database-major-version
  • jakarta.persistence.database-minor-version
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 27, 2024
@wilkinsona
Copy link
Member

See also #40177. We should probably handle these two at the same time.

@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 28, 2024
@wilkinsona wilkinsona added this to the 3.4.x milestone May 28, 2024
@wilkinsona wilkinsona changed the title Deprecate spring.jpa.database and spring.jpa.database-platform Review spring.jpa.database and spring.jpa.database-platform and their standard JPA equivalents May 28, 2024
@wilkinsona wilkinsona changed the title Review spring.jpa.database and spring.jpa.database-platform and their standard JPA equivalents Review spring.jpa.database and spring.jpa.database-platform and their standard JPA equivalents May 28, 2024
@quaff
Copy link
Contributor Author

quaff commented May 28, 2024

Please note currently it's not full supported by EclipseLink, see jakartaee/persistence#628 (comment).

@philwebb philwebb modified the milestones: 3.4.x, 3.5.x Jun 17, 2024
@Chu3laMan
Copy link
Contributor

Chu3laMan commented Jul 2, 2024 •
edited
Loading

@philwebb, @quaff I am interested to work on this issue as long as I get more explanation about this enhancement.

Thank you in advance

@wilkinsona
Copy link
Member

Thanks for the offer, @Chu3laMan, but we don't want to work on this one just yet. It's targeted at Spring Boot 3.5 which we won't start working on for 6 months or so. I also think it's likely to be one that's best handled by the core team due to how messy things are at the moment.

@wilkinsona wilkinsona added the status: pending-design-work Needs design work before any code can be developed label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.x
Development

No branches or pull requests
5 participants
@quaff @philwebb @wilkinsona @spring-projects-issues @Chu3laMan