Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the definition of EXTRACT(SECOND...) #354

Merged
merged 1 commit into from Feb 1, 2022
Merged

fix the definition of EXTRACT(SECOND...) #354

merged 1 commit into from Feb 1, 2022

Conversation

gavinking
Copy link
Contributor

EXTRACT(SECOND...) should return a floating point value because truncating fractional seconds isn't useful.

@gavinking
fix the definition of EXTRACT(SECOND...) which should return a floati…
fe01c04 
…ng point value

truncating fractional seconds isn't a good idea
@gavinking gavinking requested a review from lukasj January 30, 2022 15:24
lukasj
lukasj approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 784ca2c into jakartaee:master Feb 1, 2022
@lukasj lukasj linked an issue Feb 1, 2022 that may be closed by this pull request
Add datetime functions #102
Closed
@gavinking
Copy link
Contributor Author

Thanks @lukasj, and apologies for messing up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add datetime functions
2 participants
@gavinking @lukasj