Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE 11 Platform TCK refactoring roadmap #1126

Open
5 of 60 tasks
scottmarlow opened this issue Oct 19, 2022 · 4 comments
Open
5 of 60 tasks

EE 11 Platform TCK refactoring roadmap #1126

scottmarlow opened this issue Oct 19, 2022 · 4 comments
Labels
11.0 Issues related to the Jakarta EE 11 Platform TCK release

Comments

@scottmarlow
Copy link
Contributor

scottmarlow commented Oct 19, 2022

Continue Platform TCK refactoring using the https://github.com/eclipse-ee4j/jakartaee-tck/tree/tckrefactor branch as per jakartaee/platform#554.

Guidelines:

  1. Completing refactoring of the SE mode TCKs is required for the subset of technologies that the Platform TCK generates Standalone TCKs for, these are important to complete in time for the wave of EE 11 Spec ballots which will be blocked until needed TCKs are complete.
  2. Completing the refactoring of the EE mode tests is required for Full Platform + Web Profile profile ballots to start. Note that the TCK Process rules must be followed with regard to when test changes can be made (pending outcome specification committee issue 63).
  • Sync https://github.com/eclipse-ee4j/jakartaee-tck/tree/tckrefactor with master (EE 10) changes already done via rebase tckrefactor branch from master branch #1124.
  • Add dependency on junit #1128
  • Remove test buckets already moved out of Platform TCK (started by Scott Marlow). #1130
  • Move contents of https://github.com/eclipse-ee4j/jakartaee-tck/tree/tckrefactor/src/com/sun/ts/tests to respective new root folders (ejb30 el jsonb jta servlet websocket).
  • Add example of using OpenRewrite to refactor TCK tests. #1141
  • Refactor a small number of appclient (EE mode) tests.
  • Refactor a small number of assembly (EE mode) tests.
  • Refactor a small number of connector (EE mode) tests.
  • Refactor a small number of ejb32 (EE mode) tests.
  • Refactor a small number of ejb30 (EE mode) tests.
  • Refactor a small number of ejb (EE mode) tests.
  • Refactor a small number of el (EE mode) tests.
  • Refactor a small number of integration (EE mode) tests.
  • Refactor a small number of jacc (EE mode) tests.
  • Refactor a small number of javaee (EE mode) tests.
  • Refactor a small number of javamail (EE mode) tests.
  • Refactor a small number of jaxrs (EE mode) tests. #1156
  • Refactor a small number of jaxws (EE mode) tests.
  • Refactor a small number of jdbc (EE mode) tests.
  • Refactor a small number of jms (EE mode) tests.
  • Refactor a small number of jpa (EE mode) tests.
  • Refactor a small number of jsonp (EE mode) tests.
  • Refactor a small number of jsonb (EE mode) tests.
  • Refactor a small number of jsp (EE mode) tests.
  • Refactor a small number of jstl (EE mode) tests.
  • Refactor a small number of jta (EE mode) tests.
  • Refactor a small number of jws (EE mode) tests.
  • Refactor a small number of saaj (EE mode) tests.
  • Refactor a small number of servlet tests (TCK servlet using Arquillian #912).
  • Refactor a small number of sql (EE mode) tests.
  • Refactor a small number of websocket (EE mode) tests.
  • Refactor a small number of xa (EE mode) tests.
  • Refactor Signature test Driver and recording of new Signature for both EE + SE + Standalone mode.
  • Create milestone 1 release with EE mode support (optionally with SE mode as well).
  • Introduce (active/strong) dependencies/assertion between EE 11 Specifications and TCK tests with active reporting (for new EE 11 SPEC features).
  • Introduce common TCK result reporting.
  • Move user_guides/jakartaee into (root) user_guide folder. #1133
  • Refactor more EE mode tests for each test bucket mentioned above.
  • Add some SE tests to connector
  • Add some SE mode tests to el
  • Add some SE mode tests to jacc
  • Add some SE + EE tests to jaxws
  • Add some SE mode tests to jms
  • Add some SE mode tests to jpa
  • Add some Standalone tests to jsp
  • Add some SE + EE tests to jstl
  • Add some SE + EE tests to jta
  • Add some SE mode tests to saaj
  • Add some SE + EE tests to servlet
  • Add some SE + EE tests to websocket
  • Create milestone 2 release with (some) EE mode support + (some) SE mode.
  • Complete the refactoring of TCK tests.
  • Update the Signature testing using EE 10 SPEC APIs.
  • Create milestone 3 release (EE 10 implementations can still be used for testing). This is the last EE 10 based milestone.
  • Apply outcome of Fix handling of Specification integration TCKs.
  • Add tests to cover difficult to implement EE 11 Spec features (other tests may also be added). Confirm that each Specification team has added sufficient tests.
  • Update the documentation for the various TCKs for the milestone 4 release.
  • Create milestone 4 release for the first wave of Specification TCKs.
  • After milestone 4 release is validated by first wave of Spec projects completing their Ballots (with milestone 4 TCKs), release final first wave of TCKs reflecting their respective EE 11 Specifications requirements (with release done however TCKs are released for EE 11, maybe via Maven or current Eclipse downloads).
  • Repeat ^ for milestone 5 with second wave of Spec projects (will fill out the details soon).
    More milestones to be added here...
@scottmarlow scottmarlow added the 11.0 Issues related to the Jakarta EE 11 Platform TCK release label Oct 19, 2022
@scottmarlow
Copy link
Contributor Author

Removed guideline jakartaee/specification-committee#2:

Completing the Standalone TCKs is required for the subset of technologies that the Platform TCK generates Standalone TCKs for, these are important to complete in time for the wave of EE 11 Spec ballots which will be blocked until needed Standalone TCKs are complete. Standalone TCKs use more than Java SE technologies for testing which can include other EE specifications.

olamy pushed a commit to olamy/platform-tck that referenced this issue Nov 20, 2022
Related to jakartaee#1126:
 * Added the bom and initial dependency for JUnit 5
 * Added the initial Maven surefire and failsafe plugin definitions

Signed-off-by:Nathan Erwin <nathan.d.erwin@gmail.com>
olamy pushed a commit to olamy/platform-tck that referenced this issue Nov 20, 2022
Related to jakartaee#1126:
 * Moved the contents of the user_guides/jakartaee folder into the user_guides folder
 * Merged together the two README files

Signed-off-by:Nathan Erwin <nathan.d.erwin@gmail.com>
olamy pushed a commit to olamy/platform-tck that referenced this issue Dec 20, 2022
Related to jakartaee#1126:
 * Added the bom and initial dependency for JUnit 5
 * Added the initial Maven surefire and failsafe plugin definitions

Signed-off-by:Nathan Erwin <nathan.d.erwin@gmail.com>
@gurunrao
Copy link
Contributor

gurunrao commented Mar 28, 2023

TCK refactor module Owners and comments:

  • appclient
  • assembly
  • connector
  • ejb32
  • ejb30
  • ejb
  • el : @alwin-joseph
  • integration
  • jacc
  • javaee: doesn't have test case and not related to Specification.
  • javamail
  • jaxrs: @alwin-joseph
  • jaxws: @gurunrao
  • jdbc
  • jms
  • jpa: @gurunrao
  • jsonp
  • jsonb
  • jsp: @alwin-joseph
  • jstl
  • jta :
  • jws: Part of Standalone TCK and Platform TCK, shall we retain the code without refactor and maintain JWS as part of Standalone TCK?
  • saaj: @gurunrao
  • servlet: @olamy
  • sql: common SQL scripts used for test setup.
  • websocket: @gurunrao
  • xa

@scottmarlow
Copy link
Contributor Author

FYI https://gist.github.com/scottmarlow/cc7b689ed3ddadf1460bcea5c2f7518a is a backup of the description content before the May 3, 2023 update.

@scottmarlow
Copy link
Contributor Author

  • jaxws: Standalone TCK, shall we retain the code without refactor?
  • jws: Part of Standalone TCK and Platform TCK, shall we retain the code without refactor and maintain JWS as part of Standalone TCK?
  • saaj: Standalone TCK, shall we retain the code without refactor?

Good questions, the source for these TCKs is part of the https://github.com/jakartaee/platform-tck/tree/10.0.x branch. Regardless of what we choose to do for the EE 11 release, the source will remain in the 10.0.x branch. I'm thinking that the relevant SPEC API projects should copy the relevant Standalone TCK source (either from refactor branch if they want the Maven changes or from the 10.0.x if they prefer to use Ant in future updates to these Specification TCKs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11.0 Issues related to the Jakarta EE 11 Platform TCK release
Projects
None yet
Development

No branches or pull requests

2 participants